Please login or register.

Login with username, password and session length
Advanced search  

News:

You need/want an older version of sNews ? Download an older/unsupported version here.

Pages: [1] 2

Author Topic: mathCaptcha - sNews 1.5.31 - 06.02.2007  (Read 6134 times)

Elvino

  • Newbie
  • *
  • Karma: 0
  • Posts: 44
    • http://www.elvino.it/
mathCaptcha - sNews 1.5.31 - 06.02.2007
« on: February 06, 2007, 02:30:54 pm »

With sNews 1.5.31 UPDATED - 06.02.2007,
http://www.solucija.com/forum/viewtopic.php?id=3267

mathCaptcha not function!  :/

Patric Ahlqvist

  • Nobodys perfect, but Im pretty effing close
  • ULTIMATE member
  • ******
  • Karma: 65
  • Posts: 4867
  • I'm a self-made man and worships my creator.
    • p-ahlqvist.com
mathCaptcha - sNews 1.5.31 - 06.02.2007
« Reply #1 on: February 06, 2007, 04:39:00 pm »

Nope... not calculating as it should or rather letting posts and mails go through regardless of input. Nor do it validate...
Quote from: w3.org
Error  Line 136 column 660: document type does not allow element "input" here; missing one of "p", "h1", "h2", "h3", "h4", "h5", "h6", "div", "pre", "address", "fieldset", "ins", "del" start-tag.

...den" name="sum" id="sum" value="14" / ><p><label for="c">*
« Last Edit: March 06, 2009, 02:12:09 pm by philmoz »
Logged
"It's only dead fish that goes with the flow... "
Updated

codetwist

  • Hero Member
  • *****
  • Karma: 50
  • Posts: 940
mathCaptcha - sNews 1.5.31 - 06.02.2007
« Reply #2 on: February 06, 2007, 05:39:31 pm »

Confirmed.

Doesn't validate mathCaptcha stuff (any number will do as sum). checked code, too, really doesn't even try to compare values.

As for conforming to W3C ... output source looks weird and doesn't validate, either for captcha section.

Might be good to remove captcha validation to separate function (checkCaptcha) as it's done for user and pswd.
« Last Edit: September 24, 2007, 12:36:43 pm by codetwist »
Logged

Keyrocks

  • Doug
  • ULTIMATE member
  • ******
  • Karma: 449
  • Posts: 6020
  • Semantically Challenged
    • snews.ca
mathCaptcha - sNews 1.5.31 - 06.02.2007
« Reply #3 on: February 06, 2007, 10:49:00 pm »

Just a note... I just tested my captcha (offline of course) and it won't let me post anything with a wrong number- it seems the math answer must be correct or it won't post. This is how I'd expect it to work.
Logged
Do it now... later may not come.
-------------------------------------------------------------------------------------------------
sNews 1.6 MESU | sNews 1.6 MEMU

codetwist

  • Hero Member
  • *****
  • Karma: 50
  • Posts: 940
mathCaptcha - sNews 1.5.31 - 06.02.2007
« Reply #4 on: February 06, 2007, 11:10:51 pm »

Quote from: keyrocks
Just a note... I just tested my captcha (offline of course) and it won't let me post anything with a wrong number- it seems the math answer must be correct or it won't post. This is how I'd expect it to work.
With updated code?
Code: [Select]
$calc = (is_numeric($_POST['calc']) == is_numeric($_POST['sum'])) ? $_POST['calc'] : null;If both are numeric - captcha is happy, but not users of sNews :(
« Last Edit: September 24, 2007, 12:37:10 pm by codetwist »
Logged

codetwist

  • Hero Member
  • *****
  • Karma: 50
  • Posts: 940
mathCaptcha - sNews 1.5.31 - 06.02.2007
« Reply #5 on: February 06, 2007, 11:36:30 pm »

Initial version of mathCaptcha checking at 1.5.31 did compare values, but that was before update on 06.02:

Code: [Select]
$inputCalc = is_numeric($_POST['calc']) ? $_POST['calc'] : null;
$sum = is_numeric($_POST['sum']) ? $_POST['sum'] : null;
$calc = $inputCalc === $sum ? $inputCalc : null;
Doh ... there is even fix for this bug developed way prior this last release update :/
« Last Edit: September 24, 2007, 12:37:37 pm by codetwist »
Logged

piXelatedEmpire

  • MIA
  • ULTIMATE member
  • ******
  • Karma: 37
  • Posts: 1401
  • currently MIA
mathCaptcha - sNews 1.5.31 - 06.02.2007
« Reply #6 on: February 06, 2007, 11:50:55 pm »

Quote from: keyrocks
Just a note... I just tested my captcha (offline of course) and it won't let me post anything with a wrong number- it seems the math answer must be correct or it won't post. This is how I'd expect it to work.
Have you tried the updated code released 06.02.2007?
Please, Luka and Mika, when ANY changes are made to core PLEASE update version numbers of the package.  This is getting confusing for our members.

EDIT: the bug reported here has a FIX/PATCH released for it from the previous version: here.

How about we add these FIXES/PATCHES to the core and update the version number?
Logged
my apologies to the sNews crew, but I will be MIA for the forseeable future

codetwist

  • Hero Member
  • *****
  • Karma: 50
  • Posts: 940
mathCaptcha - sNews 1.5.31 - 06.02.2007
« Reply #7 on: February 07, 2007, 08:39:27 am »

Yes ... How about we add these FIXES/PATCHES to the core and update the version number?
« Last Edit: September 24, 2007, 12:38:07 pm by codetwist »
Logged

Keyrocks

  • Doug
  • ULTIMATE member
  • ******
  • Karma: 449
  • Posts: 6020
  • Semantically Challenged
    • snews.ca
mathCaptcha - sNews 1.5.31 - 06.02.2007
« Reply #8 on: February 07, 2007, 03:36:13 pm »

Sorry - No - I am not using the updated code released on Feb 06/02. I am using the release of Feb. 02/02.
Elvino, Pix and Codetwist... I agree. We need a better way of adding the almost-daily bugfixes to our snews.php master files. It is impossible for us to keep up with daily bugfixes. Perhaps we need to re-label 1.5.31 as being "unstable" until we reach a point where ALL of the bugs are ironed out.
Logged
Do it now... later may not come.
-------------------------------------------------------------------------------------------------
sNews 1.6 MESU | sNews 1.6 MEMU

Luka

  • Administrator
  • ULTIMATE member
  • ******
  • Karma: 36
  • Posts: 1717
    • http://www.snewscms.com
mathCaptcha - sNews 1.5.31 - 06.02.2007
« Reply #9 on: February 07, 2007, 04:01:55 pm »

Ok sorry about the confusion. It's just that we didn't want to change the version number because we fixed a small bug and addes one line of code.

The new version (1.5.32) will be released shortly and will contain math captcha sum encryption and other bug fixes.

Again, sorry for the confusion.
Logged

Patric Ahlqvist

  • Nobodys perfect, but Im pretty effing close
  • ULTIMATE member
  • ******
  • Karma: 65
  • Posts: 4867
  • I'm a self-made man and worships my creator.
    • p-ahlqvist.com
mathCaptcha - sNews 1.5.31 - 06.02.2007
« Reply #10 on: February 07, 2007, 04:09:04 pm »

Well, Pix... thanks for that refferal. I have  completely missed that fix... And it works just galantly ;)...

I believe Luka and Mika whomever, doesn't matter just missed this snippet while exchaning versions to do each part in... Must be easy to do just that and remember every freaking change, don't ya think... ?

I think the tone could be somewhat more pleasant, and then added with some respect for the work these two skinny croatians do... totally free of charge, in their spare time, regardless of spouses hanging in their bottocks screaming for affection and filthy behavior... Let's take care of 'em, huh ?

I think that a mistake has occured and we noticed it. It will be taken care of, no doubt, but hey... Let them breath, and take part in their real life's aswell....

I do however second, or third or fourth the suggestion on version alteration...
Logged
"It's only dead fish that goes with the flow... "
Updated

brauck

  • Hero Member
  • *****
  • Karma: 18
  • Posts: 556
    • http://www.hbw-webdesign.nl/
mathCaptcha - sNews 1.5.31 - 06.02.2007
« Reply #11 on: February 07, 2007, 04:15:51 pm »

I agree on this Key; I don't know which is what anymore,  I am lost  :(
I updated my sNews sites with Luka's version 1.5.31 stable released on 02/02 (which I heavily modded) but it looks like I have to do it all over again. That's a pity but it won't kill me. I better wait until we're sure that we have a stable version. :)
 ----------------------------------
Just see that I am chasing things that already are solved. Thanks Luka! :D
Logged
Confidence is reduced complexity.
brauck.nl for free css templates

Luka

  • Administrator
  • ULTIMATE member
  • ******
  • Karma: 36
  • Posts: 1717
    • http://www.snewscms.com
mathCaptcha - sNews 1.5.31 - 06.02.2007
« Reply #12 on: February 07, 2007, 04:21:08 pm »

As I said, I am sorry for the confusion. I know you have modded versions and you don't feel like applying those mods over and over again.

The new version will be released shortly within a few days when we make sure there is no more bugs. It's easy to fix one bug but it takes time to completly test the engine and make sure there's no more bugs.
Logged

brauck

  • Hero Member
  • *****
  • Karma: 18
  • Posts: 556
    • http://www.hbw-webdesign.nl/
mathCaptcha - sNews 1.5.31 - 06.02.2007
« Reply #13 on: February 07, 2007, 04:23:44 pm »

Don't take it to hard Luka, I don't blame you at all. I really appreciate all the work you and Mika do! And as I said, it won't kill me  ;)
Logged
Confidence is reduced complexity.
brauck.nl for free css templates

Keyrocks

  • Doug
  • ULTIMATE member
  • ******
  • Karma: 449
  • Posts: 6020
  • Semantically Challenged
    • snews.ca
mathCaptcha - sNews 1.5.31 - 06.02.2007
« Reply #14 on: February 07, 2007, 04:24:07 pm »

Quote from: Patric
I think the tone could be somewhat more pleasant, and then added with some respect for the work these two skinny croatians do... totally free of charge, in their spare time, regardless of spouses hanging in their bottocks screaming for affection and filthy behavior... Let's take care of 'em, huh ?
I think that a mistake has occured and we noticed it. It will be taken care of, no doubt, but hey... Let them breath, and take part in their real life's aswell....
I do however second, or third or fourth the suggestion on version alteration...
Oh... please... don't get me wrong. I DO appreciate the work those "two skinny croatians" do. Let's just say that this is a job for the... Snews Dudes! I'll start a discussion with the "Dudes" on how we might better organize the process of bug-fixing and updating. :)
Logged
Do it now... later may not come.
-------------------------------------------------------------------------------------------------
sNews 1.6 MESU | sNews 1.6 MEMU
Pages: [1] 2