sNews Forum

sNews 1.6 (previous version) => sNewsMU (sNews Multi User version) => MU issues/bugs => Topic started by: hormoSapi [hS] on September 11, 2007, 11:15:57 am

Title: Password checking
Post by: hormoSapi [hS] on September 11, 2007, 11:15:57 am
1,             I found that if you register or change you password it accept less than 4 characters and even it doesn't check their length same or not.
                e.g.: 12 and 123



Title: Re: Password checking
Post by: brauck on September 11, 2007, 12:17:20 pm
Which version of sNews are you referring to?
Title: Re: Password checking
Post by: hormoSapi [hS] on September 11, 2007, 12:35:42 pm
1.6 MU
Title: Re: Password checking
Post by: brauck on September 12, 2007, 09:07:43 am
You are right here hS, something is defenitly wrong.

I checked the source and at first site it looks ok though.

This asks for more exploration by the developers, but both bacercad and bram in particular  :) are rather busy at the moment, so we have to be a bit patient.
Title: Re: Password checking
Post by: hormoSapi [hS] on September 13, 2007, 02:17:18 am
If you don't mind i bring my solution, till the developers are busy.

It's happend cause comparing(NULL === NULL)  gives TRUE.

the way to solve that problem to change the lines number 932  and number 2469 from:

if (  $pass1 === $pass2) {

to that :

if ( $pass1 && $pass1 === $pass2) {


regards hS
Title: Re: Password checking
Post by: brauck on September 13, 2007, 10:04:34 am
Quote from: hormoSapi
If you don't mind i bring my solution


Of course I don't mind, if this solves the problem you deserve a karma; I give you one in advance  :)
Title: Re: Password checking
Post by: hormoSapi [hS] on September 13, 2007, 11:13:49 pm
Thanks.  ;D