Please login or register.

Login with username, password and session length
Advanced search  

News:

You need/want an older version of sNews ? Download an older/unsupported version here.

Author Topic: Another Minor Suggestion  (Read 1569 times)

centered

  • Guest
Another Minor Suggestion
« on: July 30, 2007, 06:50:52 pm »

Simple enough to add but still, I think it should be in the default core

Paragraph tags to the Breadcrumb function:
Code: [Select]
//BREADCRUMBS

function breadcrumbs() {
echo '<p>';

$link = '<a href="'.db('website').'';

if ($_SESSION[db('website').'Logged_In'] == token()) {echo $link.'administration/" title="'.l('administration').'">'.l('administration').'</a> '.l('divider').' ';}

$categorySEF = get_id('category'); $articleSEF = get_id('article'); $home = l('home_sef');

echo (!empty($categorySEF) || $categorySEF == $home || !empty($articleSEF)) ? $link.'" title="'.l('home').'">'.l('home').'</a>' : l('home');

$categoryName = retrieve('name', 'categories', 'seftitle', $categorySEF);

if (!empty($categoryName)) {

echo ' '.l('divider').' '.(!empty($articleSEF) ? $link.$categorySEF.'/" title="'.$categoryName.'">'.$categoryName.'</a>' : $categoryName);

}

$articleTitle = retrieve('title', 'articles', 'seftitle', $articleSEF);

if (!empty($articleTitle)) {echo ' '.l('divider').' '.$articleTitle;}

if (check_category($categorySEF) == true && $categorySEF != $home && $categorySEF != 'administration') {echo ' '.l('divider').' '.l($categorySEF);}
echo '</p>';

}
« Last Edit: August 22, 2007, 01:46:25 am by Phil Martin »
Logged

centered

  • Guest
Re: Another Minor Suggestion
« Reply #1 on: August 21, 2007, 12:57:05 pm »

Another minor suggestion I may have mentioned before...

After creating a new category, article, extra; there should be a link to go back to create another new something below the view pages, and not just the admin link in the breadcrumbs. By default of course.
Logged

Fred K

  • Still trying to learn stuff
  • ULTIMATE member
  • ******
  • Karma: 130
  • Posts: 2728
    • Personal
Re: Another Minor Suggestion
« Reply #2 on: August 21, 2007, 06:39:15 pm »

Jason, I agree with your second suggestion. Not sure about the first one though, it may not be a universal request to wrap the breadcrumbs line in <p>'s. You can just as easily wrap it in a <div>, or <span> or whatever container that fits your mood. If you want to wrap it in a <p>, simply do the
Quote
<p><?php breadcrumbs(); ?></p>
thing in index.php.

Of course, this is just my opinion.   8)

« Last Edit: August 22, 2007, 01:14:27 am by Fred K (agentsmith) »
Logged

centered

  • Guest
Re: Another Minor Suggestion
« Reply #3 on: August 22, 2007, 01:54:30 pm »

True, and duely noted. I just made the suggestion because if I recall, at default, it is not wrapped by anything.  Maybe a unsorted list would be an suggestion too, since it is a sort of list...
Logged