[MOD] Performance booster - get_id() on steroids (v.1.6, 1.5.31)

[Zucye]

Love this one!  The page had never loaded so fast.  :cool:

[Armen]

A MUST, to be included into the sNews pack... A+

[Ken Dahlin]

Very good. Thank you!

[Patric Ahlqvist]

Whohaaa, Codie... Now I've come around to try this one out, and man... It is some difference. Really awsome. Thanks.

[Keyrocks]

Just added it to my 1.6.0 vanilla install and wanted to report the same as everyone else - zoom, zoom, zoom!

[Pavel]

I have the same problem as Amak..    
codetwist your mod is super! can you please post working sNews with your mod and with subpages mod?

[Patric Ahlqvist]

I will have to comment upon this yet again, hehe... I'm a speed freak, and now I've updated all "my" sites with this, and it simply rocks... what a different. Even I do have to say that this should go into core

[codetwist]

@ Pavel : I'm not using any special subpages mod; all I know that this works without problems for regular sNews with built-in paginator without problems. After Amaks post I tested this again myself as well as few other fellows here confirmed that there seems no trouble with default sNews nor its paginator. Only potential source of problems might be some fancy subpage symbols used in urls by either some subpage MOD or by configuration of paginator prefix. If that's the case then corresponding validation rules (restrictions described in code I believe) in this get_id() MOD should be reviewed and amended as needed.

[codetwist]

@ Pavel and other subpage (subarticle) MOD users

Ok, looked into subpages MOD - it has added one more line into original get_id():

Code:

if (isset($url['2'])) {$get_id['subtitle'] = clean(cleanXSS($url['2']));}

For that one to be supported by performance booster version of get_id() You might need to add following code snippet into function getGetParm( ) (right before code line that says default : ):

Code:

     case 'subtitle' :
         if ( $url[2] ) {
            $parmValue = cleanGetSef( $url[2] );
         }
         break;

Beware, that I haven't tested this one

[Patric Ahlqvist]

I've tested it and it runs smoothly...

[Pavel]

Works good, thanks!

[Elvino]

The mod for sitemap xml  http://www.solucija.com/forum/viewtopic.php?id=3492   not work
and not work the error 404 with extension file on the url .

example:
http://snews.vietbee.net/demos/new_getid/bla-bla.php

http://snews.vietbee.net/demos/org_getid/bla-bla.php

[codetwist]

Thanx, Elvino

For sitemap.xml first section that handles case 'category' might be improved like this:

Code:

     case 'category' :
         if ( $url[0] ) {
            $parmValue = ($url[0] == 'sitemap.xml') ? $url[0] : cleanGetSef( $url[0] );
         }
         break;

For voluntary missing file quick fix idea would be to enhance cleanGetSef() a little - like adding option to have a . (dot) in sef  string:

Code:

     // String presumed
      if (! preg_match('/^[a-z0-9\-_#\.]+$/', $inSef) ) {
         // $inSef is malformed - ignored completely
         $sef = false;
      }
      else {
         // $inSef is ok - only lower case ascii, '-', '_', '#' and '.' characters are included
         $sef = $inSef;
      }

Beware, not tested these fixes yet

[quaffapint]

I can validate the sitemap.xml fix works perfectly on 1.6 - thanks, codetwist  

[piXelatedEmpire]

I've created a pretty heavily modded version of sNews1.6DE version and I have to say, this performance MOD of yours codie is awesome.  The performance difference is great!  Well done mate