[MOD]Read More link in shortened article (snews1.6)

[philmoz]

[MOD] ver 1.01 (snews1.6)

This mod will place the 'continue reading' link into the shortened article.
This will also and remove it from the default position in the 'infoline'.

find line in center() that looks like

file_include(str_replace('[break]','', $text), $shorten);

and change to

file_include(str_replace('[break]', $rmlink, $text), $shorten);

then paste this line immediately above it.

if (strlen($r['text']) > $shorten){$rmlink = ' ... <a href="'.db('website').$category.'/'.$r['seftitle'].'/" title="'.$r['title'].'">'.l('read_more').'</a>';$shorten=$shorten+strlen($rmlink);}else{$rmlink = '';}

then in file_include()

just after

$fulltext = substr($text, 0, $shorten);

put all of this...
(this will make sure [break] ends in </p> if there is a <p> in the text... it will also make sure the read more link is before the last </p>)

/* add any missing </p> and put readmore link in correct spot.*/
   if ($shorten < 9999000 && preg_match('<p>',$fulltext)){
      if(substr_count ($fulltext, '<p>') > substr_count ($fulltext, '</p>')){
         $fulltext .='</p>';
      }elseif(substr_count ($fulltext, '<p>') == substr_count ($fulltext, '</p>')){
         $endp=explode('</p>',$fulltext);$cendp=count($endp)-1;
         $endp[$cendp-1].=$endp[$cendp];$endp[$cendp]='';
         $fulltext=implode('</p>',$endp);
      }
    }
   /* end add missing </p>*/

If this operates as expected, look a bit further down in center() from the file_include line altered above, and locate

case ($tag == 'readmore'

the next line is

echo $link.$category.'/'.$r['seftitle'].'/" title="'.l('read_more').'">'.l('read_more').'</a> '; break;

change to

/*echo $link.$category.'/'.$r['seftitle'].'/" title="'.l('read_more').'">'.l('read_more').'</a> ';*/ break;

UPDATE: corrected my posted code... for some daft reason, I'd posted the default comment line instead of readmore line for removal

[tarmithius13]

I found an error in this mod.

That last part is wrong. Instead of looking for

echo $link.$category.'/'.$r['seftitle'].'/#'.l('comment').'1" title="'.l('comments').'">'.l('comments').' ('.$comments_num.') '; break;

you should be replacing the one above it:

echo $link.$category.'/'.$r['seftitle'].'/" title="'.l('read_more').'">'.l('read_more').' '; break;

with this:

/*echo $link.$category.'/'.$r['seftitle'].'/" title="'.l('read_more').'">'.l('read_more').' ';*/ break;

Your original gets rid of the comments link in the article not the read more one.

[philmoz]

You are, of course, quite correct...

My bad. Post corrected.

thx

[Patric Ahlqvist]

OK, see if I understand this... makes the "read more" INSIDE the shortened article instead of in the info line ??

[David]

Thanks philmoz!! Added on my site!

[Zucye]

change to

/*echo $link.$category.'/'.$r['seftitle'].'/" title="'.l('read_more').'">'.l('read_more').' ';*/ break;

Unless I comment the whole line I get a double link to comments when I'm in the Category view (no problem is visible on the home page)

// case ($tag == 'readmore' && strlen($r['text']) > $shorten):echo $link.$category.'/'.$r['seftitle'].'/" title="'.l('read_more').'">'.l('read_more').' '; break;

I could be something at my end.  I been changing a lot of things today   :|

[tarmithius13]

You did not see my fix above, I had the exact same issue. Phil did fix it in his original post too.

[Zucye]

You did not see my fix above, I had the exact same issue. Phil did fix it in his original post too.

Yes I saw it!  That is exactly when I started to had the problem (I had realized yesterday, He had commented the wrong line and I commented the correct whole line like I just posted)
Then Today I saw your post and commented it to just before the "echo" (because I figure you guys know better than me)
Well, like I said, is probably something wrong at my end.  Just though you might want to check.

[tarmithius13]

Not sure, it works on my end.

[philmoz]

@ zucye,
your option, I take it, works, so is an alternative.

It is important, in my post that the break; is not commented out to avoid just the issue you posted on...
but, if the whole 'case' is removed, then is not an issue...  

[Zucye]

I fixed my mess, and now it works perfectly according to your instructions.

Sorry for the confusion.

[Fred K (agentsmith)]

Thanks phil! This is one for the core...

[crm]

Very nice, thank you, exactly what I needed. Karma +1.

[Fred K (agentsmith)]

This mod --I love it, don't think anything else-- has suddenly stopped working for me. I don't know why. I have too many other mods in action to be able to guess at why it's not working. The break works, but it happens a bunch of characters after point of insertion, and the readmore link doesn't get printed.

Among the mods I have running, that are fairly recent additions to the Single User file, are:
– Keyword Cloud
– Show in front
– Links (which isn't working either)
– Related articles (which isn't working either)

All of these have worked before, but not when all are together, so it's reasonable to assume some conflict. Maybe some day I'll have time to check with a fresh sNews file...

The mod is great though, in normal settings.

[philmoz]

yep, rebuild one at a time, then see which is screwing things up...