1.5.31 Redirect removed?

[michael kennedy]

Hi all, I remember inside of 1.5.30 that after you clicked on "Edit" and saw the "Operation completed succesfully!" page, then after a few seconds it would redirect you back to the newly completed page.

But it no longer does this in 1.5.31.  How much code is it to re-insert this?

I found it useful to be able to see the newly edited article again incase I made any errors, or wanted to quickly send the URL to someone.

Or if you think it's better that it stay on the "Operation completed" page, can't we atleast get a few more links there besides "back"?

How about having that page display:

- View Article
- Administration
- Logout

Just a thought...

[tarmithius13]

I would like the redirect back. I thought I did something in my template conversions to break it but apparently it is not just me.

[piXelatedEmpire]

I was wondering what happened there... I think it is very important to either redirect to the article automatically or provide a view article link.

[KayDee]

If you want it to redirect back to the article you just edited, you just need to add back in the meta refresh line that was removed from this version.

In function processing(), find this line (around line 1540 or so)

Code:

echo notification('','','administration/'); unset($_SESSION['temp']);

and add after it:

Code:

echo '';

Change the content number from 2, to however many seconds you want it to take before it redirects you there.

[tarmithius13]

Oh thank you that works perfectly.

[michael kennedy]

Thanks, not bad for your first post KayDee.  

[Keyrocks]

Removal of this string from 1.5.31 bugged me too. Thanks for sharing this KayDee. Makes me happier. I wonder why it was removed from 1.5.31 in the first place? Must have been an oversight.

[michael kennedy]

Yeah, do you have the power to put it back in the core build keyrocks?

I also noticed what I think is another bug....  I tried changing the username and password from the admin panel and it keeps saying that the password doesn't match.  :/

[Zucye]

Removal of this string from 1.5.31 bugged me too.

Me tooo...
 

[Luka]

I decided to remove that because it seemed that sometimes you don't want it to redirect you automatically. Also, automatic redirection was removed along with some other things to keep the core secure. Is this a thing you miss?

[Zucye]

YES!

** Also the tabs on the top part of this forum suddenly don't look nice (they are overlapping).

[piXelatedEmpire]

I decided to remove that because it seemed that sometimes you don't want it to redirect you automatically. Also, automatic redirection was removed along with some other things to keep the core secure. Is this a thing you miss?

I think many of us miss this particular feature.
Thanks for the fix KayDee

[philmoz]

I decided to remove that because it seemed that sometimes you don't want it to redirect you automatically. Also, automatic redirection was removed along with some other things to keep the core secure. Is this a thing you miss?

Actually, that is fair.
different people want the redirect to take them to different places. for eg,

someone commenting -- possible redirects
--show (thank you)/(awaiting moderation) =pause=> return to article
--show (thank you)/(awaiting moderation) =pause=> return to category
--show (thank you)/(awaiting moderation) =pause=> return to home

then there is admin.
-- operation success/error message =pause=> show article
-- operation success/error message =pause=> show (return to) editor
-- operation success/error message =pause=> show admin panel

so, maybe they should be 'left out' of basic snews, and some enterprising coder make a mod that puts them back in, and makes it possible to select the site options which are then stored in settings table...

ps.. I too liked the redirect, but I like security better

[michael kennedy]

@philmoz

so back to my orginal idea - It's impossible to please everyone, so why not give them a list of several pages to then redirect to?

[KayDee]

You are all welcome, and I like security better too  

Instead of the meta refresh, you could add a list of links there instead. Here is the way I did it. There might be a better way. If someone knows of one (or I goofed somewhere), they can let me know.

First, delete the meta refresh line from before that enables the redirect. Then, add the following language variables(the original 'Back' variable is near line 186, if you wanted to keep them organized together):
 

Code:

$l['back_admin'] = 'Go To Admin Panel';
$l['back_list'] = 'Show Article List';
$l['back_article'] = 'View Edited Article';

Again, find In function processing(), find this line (around line 1540 or so)
 

Code:

echo notification('','','administration/'); unset($_SESSION['temp']);

Change that line to:
 

Code:

echo notification('','',''); unset($_SESSION['temp']);
echo '

'.l('back_admin').'

';
echo '

'.l('back_article').'

';
echo '

'.l('back_list').'

';

Now it will give you a choice of links:: 'Go To Admin Panel', 'View Edited Article', or 'Show Article List'