Please login or register.

Login with username, password and session length
Advanced search  

News:

You need/want an older version of sNews ? Download an older/unsupported version here.

Author Topic: hidden article search BUG ??  (Read 4970 times)

ha100

  • Newbie
  • *
  • Karma: 7
  • Posts: 19
    • ha100
hidden article search BUG ??
« on: October 29, 2008, 12:48:10 AM »

what is the exact purpose of hide article ability ?

because after fresh install 17rc2 and hiding welcome message search of "welcome" returns value.

but if i click the link, i got "No articles at the moment". make no sense for me.
Logged

philmoz

  • High flyer
  • ULTIMATE member
  • ******
  • Karma: 161
  • Posts: 1988
    • fiddle 'n fly
Re: hidden article search BUG ??
« Reply #1 on: October 29, 2008, 08:55:26 AM »

ok .. also spotted a formatting issue, but to this peoblem...
function search_engine()
after the $query satement, just before
if ($keyCount > 1) {

place
if(!_ADMIN){$query = $query.' a.visible = \'YES\' AND ';}

which should fix it... the above will mean admin can find it on search, but a regular surfer can't.
« Last Edit: October 29, 2008, 09:01:59 AM by philmoz »
Logged
Of all the things I have lost, it is my mind that I miss the most.

ha100

  • Newbie
  • *
  • Karma: 7
  • Posts: 19
    • ha100
Re: hidden article search BUG ??
« Reply #2 on: October 29, 2008, 09:28:24 AM »

yes i know. i did it too. but isn't this what unpublish is doing?
thats why i was asking for the purpose of it.
now we have 2 functions doing completely the same thing.
Logged

philmoz

  • High flyer
  • ULTIMATE member
  • ******
  • Karma: 161
  • Posts: 1988
    • fiddle 'n fly
Re: hidden article search BUG ??
« Reply #3 on: October 29, 2008, 10:30:14 AM »

not quite... ;)
publish/unpublish
strictly speaking, there shouldn't be an 'unpublish' option.
If something is published, it could be withdrawn (hidden) from public view, but it shouldn't be unpublished.
This then raises the issue of why the publish date isn't altered should someone unpublish an article, then republish...
>>> am I being a tad pedantic??
Logged
Of all the things I have lost, it is my mind that I miss the most.

Joost

  • Guest
Re: hidden article search BUG ??
« Reply #4 on: October 29, 2008, 04:05:34 PM »

Honestly, I did wonder too, what the 'hide' feature was for. Pedantic? I often asked myself whether a table row should have two dates:
One for the system and one for the content.
Logged

centered

  • Guest
Re: hidden article search BUG ??
« Reply #5 on: October 29, 2008, 05:00:12 PM »

Honestly, I did wonder too, what the 'hide' feature was for.

Pretty bad don't you think...
Logged

Joost

  • Guest
Re: hidden article search BUG ??
« Reply #6 on: October 29, 2008, 05:25:04 PM »

Honestly, I did wonder too, what the 'hide' feature was for.

Pretty bad don't you think...

Not really. Like I said, I haven't got a clear idea how I would have solved that "issue". Lets see what the users think about it.
Logged

funlw65

  • Hero Member
  • *****
  • Karma: 96
  • Posts: 771
    • Country Lab
Re: hidden article search BUG ??
« Reply #7 on: October 29, 2008, 05:53:48 PM »

I saw in other CMS's the possibility to restrict articles to any level in a multiuser environment...  is this equal to hidden? I don't think it is...

But publishing? Is a kind of "standard"...  Joomla, Drupal, Wordpress, e107, etc. But, don't think at those CMS's, are only few and you can say you have your own rules. Just think at how many users use them and what "publishing" mean for them ...
Logged