Please login or register.

Login with username, password and session length
Advanced search  

News:

You need/want an older version of sNews ? Download an older/unsupported version here.

Pages: 1 [2] 3

Author Topic: IMPROVE SNEWS 1.7 RC2  (Read 14313 times)

kuazo

  • Guest
Re: IMPROVE SNEWS 1.7 RC2
« Reply #15 on: October 13, 2008, 03:19:47 PM »

index.php?action=process&task=deletecomment&articleid=35&id=125

the string for deleting and editing comments has got the articleid inside.
whats the reason for that? i deleted the articledid and it still works. not needed?

index.php?action=process&task=deletecomment&id=125

looks better and also works...
Logged

centered

  • Guest
Re: IMPROVE SNEWS 1.7 RC2
« Reply #16 on: October 14, 2008, 11:35:02 PM »

index.php?action=process&task=deletecomment&articleid=35&id=125

the string for deleting and editing comments has got the articleid inside.
whats the reason for that? i deleted the articledid and it still works. not needed?

index.php?action=process&task=deletecomment&id=125

looks better and also works...

 I like my way better.... make the whole damn thing sef freindly!
domain.com/admin/process/comment/id=125

Either way, thanks for the feedback so far.. keep it coming!
Logged

Joost

  • Guest
Re: IMPROVE SNEWS 1.7 RC2
« Reply #17 on: October 15, 2008, 12:25:03 AM »


 I like my way better.... make the whole damn thing sef freindly!
domain.com/admin/process/comment/id=125

Why would you want that?
I am thinking just the opposite: sef-friendliness for the outside world only. No need to make it more complicated.
Logged

centered

  • Guest
Re: IMPROVE SNEWS 1.7 RC2
« Reply #18 on: October 15, 2008, 01:22:10 AM »

Scratches head**

Firstly, How is that more complicated?
And why would you not what to do that?
Logged

Joost

  • Guest
Re: IMPROVE SNEWS 1.7 RC2
« Reply #19 on: October 15, 2008, 01:37:37 AM »

Scratches head**

Firstly, How is that more complicated?
And why would you not what to do that?

- It is more complicated, because you need extra steps to retrieve the $_GET.
- I would not do it because it is not needed.

Now I scratch my head.

And back on topic:

index.php?action=process&task=deletecomment&articleid=35&id=125

the string for deleting and editing comments has got the articleid inside.
whats the reason for that? i deleted the articledid and it still works. not needed?

index.php?action=process&task=deletecomment&id=125

looks better and also works...

@ kuazo, you are right. It is not needed and shouldn't be there.

« Last Edit: October 15, 2008, 02:13:25 AM by Joost »
Logged

centered

  • Guest
Re: IMPROVE SNEWS 1.7 RC2
« Reply #20 on: October 15, 2008, 02:10:29 AM »

Scratches head**

Firstly, How is that more complicated?
And why would you not what to do that?

- It is more complicated, because you need extra steps to retrieve the $_GET.
- I would not do it because it is not needed.

Now I scratch my head.

No need, I am scratching enough for the whole team.

1. It is no different from the current process. 
     - if logged in & $categorySEF == 'admin' then do your admin function
2. I can't debate whether it is needed or not, which I why I said "my way"
     - check the download in my link, I've already done it and it works nicely!

I see it this way:
 - the whole system is SEF enabled, not only the front end
 - the admin links are semantically correct, other than the id#
    - admin urls like this could be possible:  domain.com/admin/page/edit/page-one/subpage-two/
 - the idea for help , admin notes, etc are now able to be used - see this post

what's neater, the top or bottom?
Code: [Select]
$frm_action = _SITE.'?action=process&task=admin_category&id='.$categoryid;
Code: [Select]
$frm_action = _SITE.'admin/category/process/id='.$categoryid;
« Last Edit: October 15, 2008, 03:01:47 AM by equilni »
Logged

Joost

  • Guest
Re: IMPROVE SNEWS 1.7 RC2
« Reply #21 on: October 15, 2008, 03:10:15 AM »

It is different from the current process. It is not simply an extension. No doubt.
index.php?action=process&task=deletecomment&id=125 is semantically correct as well and search engines have no business backstage. Therefore there is no need to make it search engine friendly.
Logged

centered

  • Guest
Re: IMPROVE SNEWS 1.7 RC2
« Reply #22 on: October 15, 2008, 03:40:35 AM »

It is different from the current process. It is not simply an extension. No doubt.
index.php?action=process&task=deletecomment&id=125 is semantically correct as well and search engines have no business backstage. Therefore there is no need to make it search engine friendly.

Dude, chill out. I am not asking to implement this into sNews at all, at least not now.
Logged

Joost

  • Guest
Re: IMPROVE SNEWS 1.7 RC2
« Reply #23 on: October 15, 2008, 03:51:53 AM »

I am perfectly fine, Jason.

This is the topic title:  IMPROVE SNEWS 1.7 RC2. ;)

This, is your response:
index.php?action=process&task=deletecomment&articleid=35&id=125

the string for deleting and editing comments has got the articleid inside.
whats the reason for that? i deleted the articledid and it still works. not needed?

index.php?action=process&task=deletecomment&id=125

looks better and also works...

 I like my way better.... make the whole damn thing sef freindly!
domain.com/admin/process/comment/id=125

Either way, thanks for the feedback so far.. keep it coming!

How could I know you were referring to anything but  SNEWS 1.7 RC2???


Logged

centered

  • Guest
Re: IMPROVE SNEWS 1.7 RC2
« Reply #24 on: October 15, 2008, 03:57:40 AM »

Just ask.

you - what are you referring to, that's not in 1.7RC?
me  - sorry, no it's not, I went off topic, my fault

Yes I did go way off topic, my fault and my apologies.
Logged

Joost

  • Guest
Re: IMPROVE SNEWS 1.7 RC2
« Reply #25 on: October 15, 2008, 04:30:00 AM »

Well, I though you were referring to sNews 1.7 when you talked about sef uri. I didn't understand you were referring to your lite version.
By the way (also off topic), I installed the earliest lite version (back then, it was  not a package) a few weeks ago.  It shows little resemblance with my project.
This project runs on my desktop. I also have a separate homepage, but the backend is the opposite: All admin pages have uri like: ?admin=content&id=3 etc. No sef uri found there, deliberately.
So there's gonna be some discussion about future sNews releases, another time. :D
Logged

philmoz

  • High flyer
  • ULTIMATE member
  • ******
  • Karma: 161
  • Posts: 1988
    • fiddle 'n fly
Re: IMPROVE SNEWS 1.7 RC2
« Reply #26 on: October 15, 2008, 12:03:10 PM »

not sure if it does work...
I removed code generating articleid=xx in the link, and get mysql errors..

It seems (I totally disown any association with that script :D :D ) that the articleid is used to return to the article after the deletion of the comment.

... but I could be wrong...
Logged
Of all the things I have lost, it is my mind that I miss the most.

kuazo

  • Guest
Re: IMPROVE SNEWS 1.7 RC2
« Reply #27 on: October 15, 2008, 12:15:09 PM »

well, i used to have notification with backhome instead of returning with meta refresh.
thats why i didn't get that it is necessary. just worked in 1.6 and not 1.7.

it was just a question... :-)
Logged

Sven

  • ULTIMATE member
  • ******
  • Karma: 88
  • Posts: 2029
  • Chasing MY bugs!
    • hiseo.fr - rédacteur Web
Re: IMPROVE SNEWS 1.7 RC2
« Reply #28 on: October 18, 2008, 10:44:14 AM »

Hi Dudes
Upgrading to RC2 I have this issue:
Quote
Unknown column 'visible' in 'field list'
???

Joost

  • Guest
Re: IMPROVE SNEWS 1.7 RC2
« Reply #29 on: October 18, 2008, 10:52:52 AM »

Good morning Philippe,

'visible' is a new field, it didn't exist in previous versions.  Did create a new database or did you alter an existing one?
Logged
Pages: 1 [2] 3